code quality fixes

Dockerfile

@@ -5,4 +5,5 @@ RUN mkdir /outputs && mkdir /inputs
 COPY ./setup.py /inputs/setup.py
 COPY ./src /inputs/src
 
-RUN cd /inputs && python ./setup.py install
+WORKDIR /inputs
+RUN python ./setup.py install

setup.py

@@ -41,7 +41,6 @@ setup_kwargs = {
     'author_email': 'dtomlinson@panaetius.co.uk',
     'maintainer': None,
     'maintainer_email': None,
-    'url': None,
     'url': 'https://github.com/dtomlinson91/musicbrainzapi-cv-airelogic',
     'package_dir': package_dir,
     'packages': packages,

src/musicbrainzapi/api/lyrics/builder.py

@@ -170,8 +170,8 @@ class LyricsBuilder(LyricsConcreteBuilder):
         avg = math.ceil(np.mean(nums))
         median = math.ceil(np.median(nums))
         std = math.ceil(np.std(nums))
-        max = math.ceil(np.max(nums))
-        min = math.ceil(np.min(nums))
+        _max = math.ceil(np.max(nums))
+        _min = math.ceil(np.min(nums))
         p_10 = math.ceil(np.percentile(nums, 10))
         p_25 = math.ceil(np.percentile(nums, 25))
         p_75 = math.ceil(np.percentile(nums, 75))
@@ -181,8 +181,8 @@ class LyricsBuilder(LyricsConcreteBuilder):
             ('avg', avg),
             ('median', median),
             ('std', std),
-            ('max', max),
-            ('min', min),
+            ('max', _max),
+            ('min', _min),
             ('p_10', p_10),
             ('p_25', p_25),
             ('p_75', p_75),
@@ -312,10 +312,10 @@ class LyricsBuilder(LyricsConcreteBuilder):
                 f'{self.artist}'
             ),
         ) as bar:
-            for id, alb in self.release_group_ids.items():
+            for _id, alb in self.release_group_ids.items():
                 resp_0 = addict.Dict(
                     musicbrainzngs.browse_releases(
-                        release_group=id,
+                        release_group=_id,
                         release_type=['album'],
                         includes=['recordings'],
                         limit=100,

src/musicbrainzapi/api/lyrics/director.py

@@ -1,6 +1,4 @@
 from __future__ import annotations
-import json
-import os
 
 import click
 

src/musicbrainzapi/cli/cli.py

@@ -30,9 +30,9 @@ class ComplexCLI(click.MultiCommand):
         rv.sort()
         return rv
 
-    def get_command(self, ctx, name):
-        mod = import_module(f'musicbrainzapi.cli.commands.cmd_{name}')
-        return getattr(mod, name)
+    def get_command(self, ctx, cmd_name):
+        mod = import_module(f'musicbrainzapi.cli.commands.cmd_{cmd_name}')
+        return getattr(mod, cmd_name)
 
 
 @click.command(cls=ComplexCLI, context_settings=CONTEXT_SETTINGS)

src/musicbrainzapi/wordcloud/__init__.py

@@ -87,7 +87,7 @@ class LyricsWordcloud:
         """
         self.lyrics_list = list()
         for i in self.all_albums_lyrics_count:
-            for album, lyric in i.items():
+            for _, lyric in i.items():
                 for track in lyric:
                     try:
                         for word in track:
@@ -141,10 +141,10 @@ class LyricsWordcloud:
         plt.axis('off')
         return self
 
-    def show_word_cloud(self):
-        """Shows the word cloud.
-        """
-        plt.show()
+    # def show_word_cloud(self):
+        # """Shows the word cloud.
+        # """
+        # plt.show()
 
     def create_word_cloud(self) -> None:
         """Creates a word cloud

tests/test_musicbrainzapi.py

@@ -1,5 +0,0 @@
-from musicbrainzapi import __version__
-
-
-def test_version():
-    assert __version__ == '0.1.0'