Merge branch 'wip/pathlib' into develop

.python-version

@@ -0,0 +1 @@
+3.7.9

README.md

@@ -1,2 +1,9 @@
 # street_group_tech_test
-Technical Test for Street Group
+
+Technical Test for Street Group for Daniel Tomlinson.
+
+## Documentation
+
+Read the documentation on github pages for instructions around running the code and a discussion on the approach.
+
+https://dtomlinson91.github.io/street_group_tech_test/

analyse_properties/main.py

@@ -1,22 +1,13 @@
-import csv
 from datetime import datetime
 import hashlib
-import io
-from importlib import resources
 import itertools
 import pathlib
 
 import apache_beam as beam
-from apache_beam.io import fileio
 
 # from analyse_properties.debug import DebugShowEmptyColumn, DebugShowColumnWithValueIn
 
 
-def csv_reader(csv_file):
-    """Read in a csv file."""
-    return csv.reader(io.TextIOWrapper(csv_file.open()))
-
-
 def slice_by_range(element, *ranges):
     """Slice a list with multiple ranges."""
     return itertools.chain(*(itertools.islice(element, *r) for r in ranges))
@@ -214,21 +205,21 @@ class ConvertDataToDict(beam.DoFn):
 
 def main():
     # Load in the data from a csv file.
-    csv_data = resources.path(
-        # "analyse_properties.data.input",
-        # "pp-monthly-update-new-version.csv"
-        "analyse_properties.data.input", "pp-complete.csv"
+    input_file = (
+        pathlib.Path(__file__).parents[1]
+        / "data"
+        / "input"
+        / "pp-monthly-update-new-version.csv"
     )
 
     with beam.Pipeline() as pipeline:
         # Load the data
-        with csv_data as csv_data_file:
-            # https://github.com/apache/beam/blob/v2.32.0/sdks/python/apache_beam/io/fileio_test.py#L155-L170
         load = (
             pipeline
-                | fileio.MatchFiles(str(csv_data_file))
-                | fileio.ReadMatches()
-                | beam.FlatMap(csv_reader)
+            | "Read input data" >> beam.io.ReadFromText(str(input_file))
+            | "Split by ','" >> beam.Map(lambda element: element.split(","))
+            | "Remove leading and trailing quotes"
+            >> beam.Map(lambda element: [el.strip('"') for el in element])
         )
 
         # Clean the data by dropping unneeded rows.
@@ -276,7 +267,9 @@ def main():
         )
 
         # Save the data to a .json file.
-        output_file = pathlib.Path(__file__).parent / "data" / "output" / "pp-complete"
+        output_file = (
+            pathlib.Path(__file__).parents[1] / "data" / "output" / "pp-complete"
+        )
         output = (
             formatted
             | "Combine into one PCollection" >> beam.combiners.ToList()
@@ -284,7 +277,6 @@ def main():
             >> beam.io.WriteToText(
                 file_path_prefix=str(output_file),
                 file_name_suffix=".json",
-                shard_name_template="",
             )
         )
 

download_data.sh

@@ -1,5 +1,5 @@
 # Full data set
-wget https://storage.googleapis.com/street-group-technical-test-dmot/pp-complete.csv -P analyse_properties/data/input
+# wget https://storage.googleapis.com/street-group-technical-test-dmot/pp-complete.csv -P data/input
 
 # Monthly update data set
-# wget https://storage.googleapis.com/street-group-technical-test-dmot/pp-monthly-update-new-version.csv -P analyse_properties/data/input
+wget https://storage.googleapis.com/street-group-technical-test-dmot/pp-monthly-update-new-version.csv -P data/input

requirements-docs.txt

@@ -1,6 +0,0 @@
-apache-beam==2.32.0; python_version >= "3.6"
-avro-python3==1.9.2.1; python_version >= "3.6"
-cachetools==4.2.2; python_version >= "3.6" and python_version < "4.0" and (python_version >= "3.6" and python_full_version < "3.0.0" or python_version >= "3.6" and python_full_version >= "3.6.0")
-certifi==2021.5.30; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.6.0" and python_version >= "3.6"
-mkdocs-material==7.3.0
-mkdocs==1.2.2; python_version >= "3.6"