From 5b668deb13979f74e9a32f7cd69fc2c276bcebc8 Mon Sep 17 00:00:00 2001
From: Daniel Tomlinson <dtomlinson@panaetius.co.uk>
Date: Fri, 29 Oct 2021 17:45:57 +0100
Subject: [PATCH] updating tests

---
 tests/test_journal/test_pages.py | 48 ++++++++++++++++++++++++++++----
 1 file changed, 42 insertions(+), 6 deletions(-)

diff --git a/tests/test_journal/test_pages.py b/tests/test_journal/test_pages.py
index 89c5d25..8ec416d 100644
--- a/tests/test_journal/test_pages.py
+++ b/tests/test_journal/test_pages.py
@@ -1,3 +1,5 @@
+import pathlib
+
 import pytest
 
 from tembo.journal.pages import PageCreator
@@ -8,24 +10,58 @@ def test_page_creator_convert_to_path_missing_base_path(caplog):
     base_path = "/some/nonexistent/path"
     page_path = "some_page"
     filename = "some_filename"
-    extension = "some_extension"
+    extension = "ex"
 
     # act
     with pytest.raises(SystemExit) as system_exit:
         PageCreator._convert_to_path(
-            base_path=base_path, page_path=page_path, filename=filename, extension=extension
+            base_path=base_path,
+            page_path=page_path,
+            filename=filename,
+            extension=extension,
         )
 
     # assert
     assert system_exit.value.code == 1
     assert caplog.records[0].levelname == "CRITICAL"
-    assert caplog.records[0].message == "Tembo base path of /some/nonexistent/path does not exist - exiting"
+    assert (
+        caplog.records[0].message
+        == "Tembo base path of /some/nonexistent/path does not exist - exiting"
+    )
 
-# @pytest.mark.parametrize([])
-def test_page_creator_convert_to_path(shared_datadir):
+
+@pytest.mark.parametrize(
+    "page_path,filename,extension",
+    [
+        ("some_pagepath", "some_filename", "ex"),
+        ("some pagepath", "some filename", "ex"),
+    ],
+)
+def test_page_creator_convert_to_path_full_path_to_file(
+    page_path, filename, extension, tmpdir
+):
     # arrange
+    path_to_file = (
+        pathlib.Path(tmpdir)
+        / pathlib.Path(page_path)
+        / pathlib.Path(filename).with_suffix(f".{extension}")
+    )
 
     # act
+    converted_path = PageCreator._convert_to_path(
+        tmpdir, page_path, filename, extension
+    )
 
     # assert
-    pass
+    assert str(path_to_file).replace(" ", "_") == str(converted_path)
+
+
+def test_page_creator_convert_to_path_full_path_no_file(tmpdir):
+    # arrange
+    full_path = pathlib.Path("/some/path")
+
+    # act
+    converted_path = PageCreator._convert_to_path("", "/some/path", "", "")
+
+    # assert
+    assert str(full_path).replace(" ", "_") == str(converted_path)