From 2175304ac9c0e46eb30de763612dc83fc630b7ed Mon Sep 17 00:00:00 2001
From: dtomlinson <dtomlinson@panaetius.co.uk>
Date: Wed, 29 Apr 2020 17:57:30 +0100
Subject: [PATCH] adding FN

---
 .ebextensions/07-custom-vpc.config |  2 +-
 todo.md                            | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/.ebextensions/07-custom-vpc.config b/.ebextensions/07-custom-vpc.config
index 7381478..d61980a 100644
--- a/.ebextensions/07-custom-vpc.config
+++ b/.ebextensions/07-custom-vpc.config
@@ -1,5 +1,5 @@
 option_settings:
   aws:ec2:vpc:
-    VPCId: "vpc-003597eb63a0a3efe"
+    VPCId: { "FN::ImportValue": "temp-vpc-ELBStrapiPublicVPC" }
     Subnets: "subnet-02cd8f7981ddfe345,subnet-02d9e1338e8d92d09,subnet-0e07d4d35394db524"
     DBSubnets: "subnet-02cd8f7981ddfe345,subnet-02d9e1338e8d92d09,subnet-0e07d4d35394db524"
diff --git a/todo.md b/todo.md
index 8b57e19..6a583a0 100644
--- a/todo.md
+++ b/todo.md
@@ -57,3 +57,31 @@ Recreate env with database, check the DB subnets - are they the same as the EC2
 Can we use cloudformation functions (imports) in .config files under option_settings? (reference a VPC that already exists?) (https://www.reddit.com/r/aws/comments/a2uoae/is_there_a_way_to_reference_an_elastic_beanstalk/) Yes?
 Yes but only certain functions: <https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/ebextensions-functions.html#ebextensions-functions-getatt>. You cannot use FN::ImportValue to reference a resource in another Cloudformation stack.
 
+Append the stackname to the outputs for the VPC and Subnets
+
+{ "Fn::ImportValue": "awseb-e-abcdefghijklmno-AutoScalingGroup" }
+
+Use join for subnets Name: !Join [ ":", [ !Ref "AWS::StackName", AccountVPC ] ]
+
+Updating 07 config to accept a parameter
+
+
+Append the stackname to the outputs for the VPC and Subnets
+
+!Sub "${AWS::StackName}-VPCID"
+
+Name: !Sub "${AWS::StackName}-ELBStrapiPublicVPC"
+Name: !Sub "${AWS::StackName}-ELBStrapiSubnet0"
+Name: !Sub "${AWS::StackName}-ELBStrapiSubnet1"
+Name: !Sub "${AWS::StackName}-ELBStrapiSubnet2"
+
+temp-vpc-ELBStrapiPublicVPC
+temp-vpc-ELBStrapiSubnet0
+temp-vpc-ELBStrapiSubnet1
+temp-vpc-ELBStrapiSubnet2
+
+{ "Fn::ImportValue": "awseb-e-abcdefghijklmno-AutoScalingGroup" }
+
+Use join for subnets   Name: !Join [ ":", [ !Ref "AWS::StackName", AccountVPC ] ]
+
+Updating 07 config to accept a parameter